directfb: Use QPlatformPixmap::fromFile for Qt resources
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>
Mon, 23 Jan 2012 12:49:35 +0000 (13:49 +0100)
committerQt by Nokia <qt-info@nokia.com>
Thu, 19 Apr 2012 05:32:11 +0000 (07:32 +0200)
commit6878047681820124e58d33355f35a7fc114a47bc
tree4b7487b7a75261ba21cb7c2a772547014dd18db6
parent36820a366bf678cfcf184cb6a30f3e81c9aa0576
directfb: Use QPlatformPixmap::fromFile for Qt resources

Move to fromFile to load Qt resources for two reasons. The
first is that ::fromData creates a QBuffer on our raw data
and is passing that to the QImageReaders. Right now we there
is a QFile -> QByteArray -> QBuffer transition that wastes
cycles. The other reason is that QPlatformPixmap::fromData
did/does not check if the decoded image is null and might
cause a crash because of that.

Change-Id: I800bfe4cd9b5d6a0d3531ed33f4228770703e94f
Original-Id: I7cb92d84874323e7205ab28883cc0fe9ecca1e27
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
src/plugins/platforms/directfb/qdirectfbblitter.cpp