Windows - fix getsockopt calls for narrower than int options
authorShane Kearns <ext-shane.2.kearns@nokia.com>
Mon, 20 Feb 2012 18:48:10 +0000 (18:48 +0000)
committerQt by Nokia <qt-info@nokia.com>
Wed, 7 Mar 2012 13:08:57 +0000 (14:08 +0100)
commit3a57243fbffb771c0991c99d93ac9b9fcf4fc4ee
treebd9b305c68c5728fa2c926c411fbd38328c7acea
parentc1a0e58df7f49ef116a843ca58defe6564808098
Windows - fix getsockopt calls for narrower than int options

Windows unhelpfully writes to only one byte of the output buffer
when getsockopt is called for a boolean option. Therefore we have
to zero initialise the int rather than initialising to -1 as was
done before.
This in general only works for little endian architecture, because
the word would look like 0x01000000 on big endian. So I have added
some compile time asserts in the assumption that windows is always
little endian. This is ok for comparisons with 0/false, but not
comparisons with true or nonzero values.

Task-number: QTBUG-23488
Change-Id: I3c586d1ada76465fc045a82661f289920c657a4c
Reviewed-by: Richard J. Moore <rich@kde.org>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Andreas Holzammer <andreas.holzammer@kdab.com>
(cherry picked from commit 46e4a9d5231e2d9e35424259858713ca539b8e30)
src/network/socket/qnativesocketengine_win.cpp
tests/auto/qtcpsocket/tst_qtcpsocket.cpp