Commit 302c8687f929ea29beba02a65a52c4507d7ab1c2

thierry
Tue Jun 16 15:49:12 GMT 2009

Tree SHA1: 40be522
Parent SHA1: 45d48b6 (Removed trailing whitespace.)
raw diff | raw patch

Fixed a bottleneck in itemviews that would ask for an update outside
of the boundaries of the viewport.

Now we catch this and don't call update. This was a performance
regression against 4.4.

Task-number: 256183
Reviewed-by: alexis

Diff rendering mode:
inline
side by side


2902	2902	void QAbstractItemView::update(const QModelIndex &index)
2903	2903	{
2904	2904	Q_D(QAbstractItemView);
2905		if (index.isValid())
2906		d->viewport->update(visualRect(index));
	2905	if (index.isValid()) {
	2906	const QRect rect = visualRect(index);
	2907	//this test is important for peformance reason
	2908	//For example in dataChanged we simply update all the cells without checking
	2909	//it can be a major bottleneck to update rects that aren't even part of the viewport
	2910	if (d->viewport->geometry().intersects(rect))
	2911	d->viewport->update(rect);
	2912	}
2907	2913	}
2908	2914
2909	2915	/*!

Commit 302c8687f929ea29beba02a65a52c4507d7ab1c2

Comments

Add a new comment:

Add your comment