Reviewing merge request #69: API cleanup
as QChar is acrually an ushort, replace 'const QChar &' with 'QChar ' where appropriate
Commits that would be merged:
Comments
Pushed new version 1
Looks good to me.
staged. note that its “its address”, not “it’s address”. ;)
the CI system spews out a shitload of messages like this:
In file included from ../../../include/QtTest/qtest.h:2,
from tst_v8.cpp:42:
../../../include/QtTest/../../src/testlib/qtest.h:110: error: template-id 'toString<>' for 'char* QTest::toString(QChar)' does not match any template declaration
make[5]: *** [.obj/release-shared/tst_v8.o] Error 1
make[4]: *** [sub-v8-make_default] Error 2
make[3]: *** [sub-v8-pro-make_default] Error 2
fwiw, any particular reason not to squash the commits?
ooh…
I didn’t try the gui/test -related changes as qtbase:gui doesn’t build to me.
any particular reason not to squash the commits?
1) char/string + all others; 2) squashed version is too long to be displayed in browser (thx to gitorious)
Thank you for your contribution. With the launch of the Qt Project
under Open Governance [1], you can now contribute your changes via Gerrit [2].
At the same time, contributions via Gitorious can no longer be merged.
We would still like to see your patch on the new platform, and wish for you to become
a member of the Qt Project. Please read [3] and in particular [4] to familiarize yourself
with the new tools. You will still find a read-only mirror of all Qt repositories on
Gitorious.
With a much wider set of possible reviewers, we are also looking forward to better
response times to contributions. Looking forward to your patch!
The Nokia Qt team
[1] http://labs.qt.nokia.com/2011/10/21/the-qt-project-is-live/
[2] http://codereview.qt-project.org
[3] http://www.qt-project.org
[4] http://developer.qt.nokia.com/wiki/Gerrit_Introduction


Add a new comment:
Login or create an account to post a comment