Reviewing merge request #451: Send finer grained updates in a Cocoa paint event

This has been sitting around a while, but I finally got around to submitting it.

If you have two small updates on a widget, Cocoa normally just sends a large rectangle in its drawRect, that is just passed along. It *is* possible to actually get the list of specific rectangles and send those as our region. On some applications (like my Vim port), this results in much less painting and an easier to understand Quartz Debug output. I'm not sure how much the data-impedence cost is, but I leave that to you guys.

Commits that would be merged:

Version 1
  • Version 1
  • 7d7dad1
  • hjk
over 2 years ago
  • 5a0d63f
  • kh1
over 2 years ago
  • 81be882
  • kh1
over 2 years ago
  • aba4888
  • kh1
over 2 years ago
  • 005313b
  • kh1
over 2 years ago
  • c8fa42b
  • kh1
over 2 years ago
  • 35d0565
  • Thiago Macieira
over 2 years ago
  • fb92097
  • Thiago Macieira
over 2 years ago
  • 70a24d4
  • Thiago Macieira
over 2 years ago
  • 1c69428
  • Jason McDonald
over 2 years ago
  • 4cb7008
  • Jason McDonald
over 2 years ago
  • 714e0f1
  • Jason McDonald
over 2 years ago
  • 0b9aa36
  • Thiago Macieira
over 2 years ago
  • 6c3f538
  • Thiago Macieira
over 2 years ago
  • 8aea7e0
  • Rohan McGovern
over 2 years ago
  • 637bbb7
  • Thiago Macieira
over 2 years ago
  • 85e3154
  • Rohan McGovern
over 2 years ago
  • 01f4834
  • Andy Shaw
over 2 years ago
  • 1e6a4aa
  • Jason McDonald
over 2 years ago
  • 62d08b6
  • Jason McDonald
over 2 years ago
  • 36ec923
  • Olivier Goffart
over 2 years ago
  • b17cc49
  • Olivier Goffart
over 2 years ago
  • a325601
  • Olivier Goffart
over 2 years ago
  • 84192b4
  • Olivier Goffart
over 2 years ago
  • 934a67b
  • Robert Griebl
over 2 years ago
  • 5f885e6
  • Robert Griebl
over 2 years ago
  • 8ed55cb
  • Thiago Macieira
over 2 years ago
  • e8455f8
  • Simon Hausmann
over 2 years ago
  • ebd0823
  • Thiago Macieira
over 2 years ago
  • 8be000b
  • Simon Hausmann
over 2 years ago
  • 29dac8a
  • Warwick Allison
over 2 years ago
  • 9f80bac
  • Warwick Allison
over 2 years ago
  • b68c5cd
  • Simon Hausmann
over 2 years ago
  • 8972f99
  • Simon Hausmann
over 2 years ago
  • 8a441f3
  • Daniel Molkentin
over 2 years ago
  • 56b3d84
  • Daniel Molkentin
over 2 years ago
  • 36304a7
  • Iain
over 2 years ago
  • 86b4c12
  • Thiago Macieira
over 2 years ago
  • badcaa7
  • Thiago Macieira
over 2 years ago
  • 4d33c51
  • Thiago Macieira
over 2 years ago
  • 67b794d
  • Jan-Arve Sæther
over 2 years ago
  • ab35c0b
  • Jan-Arve Sæther
over 2 years ago
  • 564f65b
  • Thiago Macieira
over 2 years ago
  • 58563dc
  • Thiago Macieira
over 2 years ago
  • f86eddc
  • Thiago Macieira
over 2 years ago
  • 97dbf38
  • Oswald Buddenhagen
over 2 years ago
  • fd7188e
  • Morten Engvoldsen
over 2 years ago
  • 468bd5a
  • Thiago Macieira
over 2 years ago
  • e5bcddb
  • Thiago Macieira
over 2 years ago
  • 4765c89
  • Thiago Macieira
over 2 years ago
  • ead7fd2
  • Thiago Macieira
over 2 years ago
  • b2cf158
  • Morten Sorvig
over 2 years ago
  • 7915d20
  • Martin Pejcoch
over 2 years ago
  • 1118181
  • Andrew den Exter
over 2 years ago
  • c5bfbe2
  • Warwick Allison
over 2 years ago
  • af1fa7f
  • Thiago Macieira
over 2 years ago
  • a761b0e
  • Gunnar Sletta
over 2 years ago
  • 5552e1c
  • Thiago Macieira
over 2 years ago
  • 07c5ded
  • Gunnar Sletta
over 2 years ago
  • 006c994
  • Gunnar Sletta
over 2 years ago
  • 511c434
  • Morten Johan Sørvig
over 2 years ago
  • b7ba4cc
  • Gunnar Sletta
over 2 years ago
  • af92d15
  • Thiago Macieira
over 2 years ago
  • 55b7112
  • Gunnar Sletta
over 2 years ago
  • 90b7aba
  • Gunnar Sletta
over 2 years ago
  • 0fec70a
  • Morten Johan Sørvig
over 2 years ago
  • 9b0c0fa
  • Gunnar Sletta
over 2 years ago
  • 8f4160b
  • Thiago Macieira
over 2 years ago
  • 732bd68
  • Leonardo Sobral Cunha
over 2 years ago
  • e336c7a
  • Thiago Macieira
over 2 years ago
  • e535343
  • Morten Johan Sørvig
over 2 years ago
  • 187be1c
  • ck
over 2 years ago
  • b1aa873
  • ck
over 2 years ago
  • 58ed656
  • kh1
over 2 years ago
  • bb19f07
  • kh1
over 2 years ago
  • 8e70c55
  • kh1
over 2 years ago
  • 43d654e
  • Daron Edie
over 2 years ago
  • 8d989dc
  • ck
over 2 years ago
  • 47cb390
  • ck
over 2 years ago
  • 51ae911
  • ck
over 2 years ago
  • e1c68e8
  • ck
over 2 years ago
  • 6982e18
  • ck
over 2 years ago
  • 9c0196d
  • Markus Goetz
over 2 years ago
  • 2f9222f
  • ck
over 2 years ago
  • 1a693bc
  • ck
over 2 years ago
  • 3458ccf
  • ck
over 2 years ago
  • d895af5
  • ck
over 2 years ago
  • cd4cab0
  • Thiago Macieira
over 2 years ago
  • 55b8a57
  • Markus Goetz
over 2 years ago
  • 7af4aba
  • kh1
about 2 years ago
  • 9659294
  • ck
about 2 years ago
  • e59578e
  • hjk
about 2 years ago
  • b60ed9f
  • ck
about 2 years ago
  • 951ccea
  • Kim Motoyoshi Kalland
about 2 years ago
  • 45a5c5e
  • ck
about 2 years ago
  • fc0403d
  • ck
about 2 years ago
  • 8841292
  • ck
about 2 years ago
  • 9cd0eda
  • ck
about 2 years ago
  • cf44101
  • ck
about 2 years ago
  • 149b13b
  • Thiago Macieira
about 2 years ago
  • 01733c6
  • Friedemann Kleint
about 2 years ago
  • b4790f3
  • Thierry Bastian
about 2 years ago
  • 4c34411
  • Thierry Bastian
about 2 years ago
  • c89baf1
  • Thierry Bastian
about 2 years ago
  • d84e070
  • Thierry Bastian
about 2 years ago
  • 7cc0f75
  • Thierry Bastian
about 2 years ago
  • f3556c2
  • ck
about 2 years ago
  • f7dbb28
  • ck
about 2 years ago
  • 5c4fce6
  • kh1
about 2 years ago
  • 4c7d869
  • Jens Bache-Wiig
about 2 years ago
  • f784f86
  • Thierry Bastian
about 2 years ago
  • 2136c98
  • Thierry Bastian
about 2 years ago
  • 24673c6
  • ck
about 2 years ago
  • 06ae2e3
  • Thierry Bastian
about 2 years ago
  • b961124
  • ck
about 2 years ago
  • 49e3517
  • ck
about 2 years ago
  • ceec6c8
  • ck
about 2 years ago
  • 5daca04
  • hjk
about 2 years ago
  • 079f090
  • ck
about 2 years ago
  • af651b7
  • ck
about 2 years ago
  • 8226392
  • Morten Johan Sørvig
about 2 years ago
  • a51ccec
  • Morten Johan Sørvig
about 2 years ago
  • c086dc9
  • Morten Johan Sørvig
about 2 years ago
  • 89478a9
  • Morten Johan Sørvig
about 2 years ago
  • c2a4a1b
  • ck
about 2 years ago
  • e58b7f0
  • Thiago Macieira
about 2 years ago
  • b7e08e8
  • Oswald Buddenhagen
about 2 years ago
  • 14fcc48
  • Oswald Buddenhagen
about 2 years ago
  • 5c488b7
  • Olivier Goffart
about 2 years ago
  • f3ac20a
  • Olivier Goffart
about 2 years ago
  • b881d8f
  • Bradley T. Hughes
about 2 years ago
  • 1d037c5
  • Morten Johan Sørvig
about 2 years ago
  • ae0c720
  • Kim Motoyoshi Kalland
about 2 years ago
  • 0fc7c73
  • Leonardo Sobral Cunha
about 2 years ago
  • c0d237b
  • Thiago Macieira
about 2 years ago
  • 2eb96bf
  • Thiago Macieira
about 2 years ago
  • 204fc5e
  • Thiago Macieira
about 2 years ago
  • b930008
  • Thiago Macieira
about 2 years ago
  • 3f18623
  • Alexis Menard
about 2 years ago
  • d6c21ef
  • ck
about 2 years ago
  • 6aee4cb
  • ck
about 2 years ago
  • 02c1e33
  • ck
about 2 years ago
  • b15b08e
  • ck
about 2 years ago
  • 7e80ffd
  • ck
about 2 years ago
  • c7739f7
  • Thiago Macieira
about 2 years ago
  • cf5d234
  • Thiago Macieira
about 2 years ago
  • d1a28d1
  • mae
about 2 years ago
  • 6001ef3
  • Richard Moe Gustavsen
about 2 years ago
  • 7c5d48e
  • ck
about 2 years ago
  • 067cab5
  • Richard Moe Gustavsen
about 2 years ago
  • 08de984
  • Richard Moe Gustavsen
about 2 years ago
  • cbdf3dc
  • Olivier Goffart
about 2 years ago
  • 9093d6c
  • Simon Hausmann
about 2 years ago
  • 35a740f
  • kh1
about 2 years ago
  • 5cd4bad
  • Richard Moe Gustavsen
about 2 years ago
  • e413a4f
  • ck
about 2 years ago
  • 20d65de
  • ck
about 2 years ago
  • 44aa429
  • Eskil Abrahamsen Blomf...
about 2 years ago
  • 0c9aa0c
  • ck
about 2 years ago
  • e1c515f
  • Thierry Bastian
about 2 years ago
  • d3dbb40
  • ck
about 2 years ago
  • c4cd151
  • ck
about 2 years ago
  • 2bfb839
  • Olivier Goffart
about 2 years ago
  • ccc3497
  • Olivier Goffart
about 2 years ago
  • 3bce78f
  • Olivier Goffart
about 2 years ago
  • 258bc1c
  • Thiago Macieira
about 2 years ago
  • b81b8e4
  • Thierry Bastian
about 2 years ago
  • c8711de
  • ck
about 2 years ago
  • 5b2cdd7
  • ck
about 2 years ago
  • 6135da7
  • Denis Dzyubenko
about 2 years ago
  • 4184664
  • Denis Dzyubenko
about 2 years ago
  • fc73e6e
  • Denis Dzyubenko
about 2 years ago
  • 445f8bb
  • Richard Moe Gustavsen
about 2 years ago
  • bc8e870
  • ck
about 2 years ago
  • 9215506
  • Bradley T. Hughes
about 2 years ago
  • d7159b1
  • Richard Moe Gustavsen
about 2 years ago
  • 4a98261
  • ck
about 2 years ago
  • 46e080b
  • Oswald Buddenhagen
about 2 years ago
  • b6352d4
  • Oswald Buddenhagen
about 2 years ago
  • d99a9ff
  • Eskil Abrahamsen Blomf...
about 2 years ago
  • 3b544e5
  • Eskil Abrahamsen Blomf...
about 2 years ago
  • 9364907
  • Bradley T. Hughes
about 2 years ago
  • 38181f2
  • Bradley T. Hughes
about 2 years ago
  • f2321e2
  • Bradley T. Hughes
about 2 years ago
  • 1908e12
  • Bradley T. Hughes
about 2 years ago
  • 454e87a
  • Bradley T. Hughes
about 2 years ago
  • bff37a8
  • ck
about 2 years ago
  • 764c4a4
  • mae
about 2 years ago
  • 91f03a8
  • ck
about 2 years ago
  • 767260d
  • ck
about 2 years ago
  • 2e0fb59
  • ck
about 2 years ago
  • efa48b0
  • jasplin
about 2 years ago
  • fcf91a2
  • Olivier Goffart
about 2 years ago
  • 7cd3470
  • hjk
about 2 years ago
  • aa5fb54
  • Simon Hausmann
about 2 years ago
  • ac41c7d
  • Kim Motoyoshi Kalland
about 2 years ago
  • 6c10c6b
  • Kim Motoyoshi Kalland
about 2 years ago
  • c9a1070
  • Kim Motoyoshi Kalland
about 2 years ago
  • 3e9d2ca
  • Kim Motoyoshi Kalland
about 2 years ago
  • 0a91e90
  • Thiago Macieira
about 2 years ago
  • da89e73
  • Thiago Macieira
about 2 years ago
  • 63c8293
  • ck
about 2 years ago
  • a66af3b
  • jasplin
about 2 years ago
  • 8cb83f3
  • Kim Motoyoshi Kalland
about 2 years ago
  • d4005e2
  • Prasanth Ullattil
about 2 years ago
  • f0c5c37
  • ck
about 2 years ago
  • 22573dd
  • Kim Motoyoshi Kalland
about 2 years ago
  • 875afab
  • Richard Moe Gustavsen
about 2 years ago
  • 464306d
  • Richard Moe Gustavsen
about 2 years ago
  • ef5291b
  • Joerg Bornemann
about 2 years ago
  • e60dbc9
  • Joerg Bornemann
about 2 years ago
  • c5e5998
  • Joerg Bornemann
about 2 years ago
  • 4376f88
  • Joerg Bornemann
about 2 years ago
  • 2427055
  • Thiago Macieira
about 2 years ago
  • e5c5213
  • Kim Motoyoshi Kalland
about 2 years ago
  • 592dc59
  • Kim Motoyoshi Kalland
about 2 years ago
  • ec452c7
  • Richard Moe Gustavsen
about 2 years ago
  • 5356d37
  • Richard Moe Gustavsen
about 2 years ago
  • 81d06f7
  • Kim Motoyoshi Kalland
about 2 years ago
  • 2176a58
  • Richard Moe Gustavsen
about 2 years ago
  • b1b8ff4
  • Morten Johan Sørvig
about 2 years ago
  • 3d16f0d
  • Morten Johan Sørvig
about 2 years ago
  • 6abee18
  • Morten Johan Sørvig
about 2 years ago
  • dbc4a07
  • Thiago Macieira
about 2 years ago
  • d149a3f
  • Olivier Goffart
about 2 years ago
  • 7e77574
  • Thiago Macieira
about 2 years ago
  • 7fc53c1
  • Thiago Macieira
about 2 years ago
  • e2baf96
  • Thiago Macieira
about 2 years ago
  • e727467
  • Morten Johan Sørvig
about 2 years ago
  • 6f173f9
  • Morten Johan Sørvig
about 2 years ago
  • 2399046
  • Alexis Menard
about 2 years ago
  • a8e3cca
  • Alexis Menard
about 2 years ago
  • 0647ea3
  • Joerg Bornemann
about 2 years ago
  • 58112b1
  • Rhys Weatherley
about 2 years ago
  • 4d786b6
  • Richard Moe Gustavsen
about 2 years ago
  • 5339d24
  • Prasanth Ullattil
about 2 years ago
  • 63e248a
  • Prasanth Ullattil
about 2 years ago
  • 9701f97
  • ck
about 2 years ago
  • 59a8e02
  • Jan-Arve Sæther
about 2 years ago
  • 9b0502a
  • Olivier Goffart
about 2 years ago
  • 2e62227
  • Thiago Macieira
about 2 years ago
  • 319b026
  • Alexis Menard
about 2 years ago
  • 158d63b
  • Alexis Menard
about 2 years ago
  • d93b2ff
  • Denis Dzyubenko
about 2 years ago
  • 2f500df
  • Denis Dzyubenko
about 2 years ago
  • cb0de81
  • ck
about 2 years ago
  • 56d0ea1
  • ck
about 2 years ago
  • e8f45c5
  • Thiago Macieira
about 2 years ago
  • 705ebae
  • Morten Johan Sørvig
about 2 years ago
  • b73b5e5
  • Morten Johan Sørvig
about 2 years ago
  • ab2f88e
  • Simon Hausmann
about 2 years ago
  • aca933d
  • Richard Moe Gustavsen
about 2 years ago
  • 0e6abff
  • Richard Moe Gustavsen
about 2 years ago
  • b958102
  • Markus Goetz
about 2 years ago
  • 22796b3
  • Thiago Macieira
about 2 years ago
  • b38da98
  • Peter Hartmann
about 2 years ago
  • 737161b
  • Thiago Macieira
about 2 years ago
  • 52ecdf5
  • Richard Moe Gustavsen
about 2 years ago
  • 20e0e7a
  • Richard Moe Gustavsen
about 2 years ago
  • 7d1e486
  • Thiago Macieira
about 2 years ago
  • fac3083
  • ck
about 2 years ago
  • 54d1ad1
  • ck
about 2 years ago
  • 9056392
  • ck
about 2 years ago
  • c5a226d
  • Alexis Menard
about 2 years ago
  • 9b59e3a
  • ck
about 2 years ago
  • 035bb4a
  • ck
about 2 years ago
  • 9fc2d96
  • ck
about 2 years ago
  • 6c5c231
  • ck
about 2 years ago
  • 2d1f2bb
  • Morten Johan Sørvig
about 2 years ago
  • 27ed53b
  • Richard Moe Gustavsen
about 2 years ago
  • 7dee69c
  • Richard Moe Gustavsen
about 2 years ago
  • f62d047
  • Thiago Macieira
about 2 years ago
  • 61ce98e
  • Kim Motoyoshi Kalland
about 2 years ago
  • b80ac6d
  • kh1
about 2 years ago
  • 1969f1f
  • Kim Motoyoshi Kalland
about 2 years ago
  • 3d6cfbb
  • Leonardo Sobral Cunha
about 2 years ago
  • 01a54a8
  • ck
about 2 years ago
  • 6b92cb8
  • Leonardo Sobral Cunha
about 2 years ago
  • b739ad7
  • ck
about 2 years ago
  • c74dead
  • Leonardo Sobral Cunha
about 2 years ago
  • 613be7c
  • kh1
about 2 years ago
  • 8e65adc
  • Thiago Macieira
about 2 years ago
  • dc8fb82
  • ck
about 2 years ago
  • bc842d0
  • Thierry Bastian
about 2 years ago
  • e29453a
  • Thierry Bastian
about 2 years ago
  • 2f48ff8
  • Thierry Bastian
about 2 years ago
  • 178f722
  • Richard Moe Gustavsen
about 2 years ago
  • 2c3f2a0
  • ck
about 2 years ago
  • a259511
  • Thiago Macieira
about 2 years ago
  • 1ad847d
  • Thiago Macieira
about 2 years ago
  • 91eec1a
  • Thiago Macieira
about 2 years ago
  • 08ff927
  • Thierry Bastian
about 2 years ago
  • 4423267
  • João Abecasis
about 2 years ago
  • 784946b
  • João Abecasis
about 2 years ago
  • 0f85193
  • João Abecasis
about 2 years ago
  • 31d18e0
  • João Abecasis
about 2 years ago
  • 2547e8d
  • João Abecasis
about 2 years ago
  • cb83e60
  • root
about 2 years ago
  • 5d524d7
  • root
about 2 years ago
  • 0fed2c3
  • root
about 2 years ago
Showing 26af4d5-7d7dad1

Comments

→ State changed from New to Rejected

Hum, did you merge the right branch?
The commit has nothing to do with the merge description.

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository