No such tree SHA1 was found

Reviewing merge request #436: Fix toAce for hostnames ending with .

Full hostnames, such as those returned by bonjour lookups etc, end with a dot. QHostInfo fails to resolve these, as the call to QUrl::toAce fails because the hostname ends with an empty component.

Requested by: Thorvald Natvig
Status: Merged
Source repository: slicers-clone:acewithdot
Target repository: qt:master
Created at: January 20th, 2010 06:41

Commits that would be merged:

Version 1

Version 1

1969f1f
bf921ad

Fix QUrl::toAce for domains with dot at end

Showing

Showing 1969f1f-bf921ad

Comments
Include comments entered inline

Ok, I give in.

You’re the fourth person ask this, so I am accepting it.

Thiago Macieira | 2010-01-22 14:02:35 UTC

→ State changed from New to Merged

Merged as df01c399c0d9f3412c872ad9ccb7342af0a44ea2

Thiago Macieira | 2010-01-22 14:07:07 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/436

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/qt/qt.git \
  refs/merge-requests/436

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/436

# To apply the changes to your branch:
git checkout master
git merge merge-requests/436
git push origin master

Reviewing merge request #436: Fix toAce for hostnames ending with .

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline