A Git timeout occured. Only metadata is being displayed

Reviewing merge request #435: Type signature based method identification for qdbusviewer

Related to: QTBUG-7415

Since qdbusviewer only matches methods by name, overloaded methods can not be called. This patch adds D-bus type signature matching in addition to the name match.

Requested by: Kimmo Kotajärvi
Status: Merged
Source repository: kkos-qt:qdbusviewer-signaturecheck
Target repository: qt:master
Created at: January 19th, 2010 10:35

Commits that would be merged:

Version 1

Version 1

Comments
Include comments entered inline

Hi,

sorry for the long delay, but the patch broke calling a D-Bus method with a double click, since the D-Bus structure was not updated in
void QDBusViewer::activate(const QModelIndex &item)

I fixed that now, and the updated QDBusViewer should appear in the 4.7 branch very soon.

Thanks for the patch,
Harald

Harald Fernengel | 2010-03-11 13:19:13 UTC

→ State changed from New to Merged

Harald Fernengel | 2010-03-11 13:40:44 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/435

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/qt/qt.git \
  refs/merge-requests/435

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/435

# To apply the changes to your branch:
git checkout master
git merge merge-requests/435
git push origin master

Reviewing merge request #435: Type signature based method identification for qdbusviewer

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline