Reviewing merge request #434: Fix QSslCertificate utf8/16 issuerInfo/subjectInfo characters

Use X509_NAME_print_ex instead X509_NAME_oneline,
also fix QTBUG-6466 and minor cleanup

Commits that would be merged:

Version 1
  • Version 1
  • da5033d
  • 6d159d1

    • Fix QSslCertificate utf8/16 issuerInfo/subjectInfo characters

Showing da5033d-6d159d1

Comments

→ State changed from New to Revise and resubmit

I need an autotest for this. I don’t know what your fix is doing.

Please modify tests/auto/qsslcertificate/certificates/gencertificates.sh to generate an extra certificate that shows where this problem would appear. Then add a test to QSslCertificate that shows it working properly.

avatar Thiago Macieira | 2010-01-27 10:02:28 UTC

I was hoping get it fixed here faster than going through the paying customer issuer tracer, but seems I have to submit ticket there. No time to create all the test cases.

Anyway here is how to repeat
openssl req -out req.pem -new -key rsa-pri-1024.pem -nameopt utf8 -utf8 -subj “/CN=öäõüname\/with\/slashes/C=NO”

./test
“\xF6\xE4\xF5\xFCname/with/slashes”

avatar Raul Metsma | 2010-01-27 10:50:44 UTC

→ State changed from Revise and resubmit to Rejected

I'm sorry, I'm not allowed to accept a merge request for SSL code.

avatar Thiago Macieira | 2010-02-05 21:33:56 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository