Reviewing merge request #430: Fix for QTBUG-7307 (Delegate leaks for naive Cocoa Toolbars (unified toolbar))

The delegate that is created for the Cocoa Toolbar when using unified Toolbars is never released.

Requested by: Nils Jeisecke
Status: Merged
Source repository: njeiseckes-clone:njeiseck/cocoa-toolbar-leak
Target repository: qt:4.6
Created at: January 13th, 2010 12:25

Commits that would be merged:

Version 1

Version 1

1cb8e4b
4615b47

Cleanup Toolbar delegate

Showing

Showing 1cb8e4b-4615b47

Comments
Include comments entered inline

→ State changed from New to Reviewing

Prasanth Ullattil | 2010-01-19 15:11:37 UTC

→ State changed from Reviewing to Merged

Should be available in 4.6.2

Prasanth Ullattil | 2010-01-19 16:51:45 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/430

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/qt/qt.git \
  refs/merge-requests/430

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit 4.6..merge-requests/430

# To apply the changes to your branch:
git checkout 4.6
git merge merge-requests/430
git push origin 4.6

Reviewing merge request #430: Fix for QTBUG-7307 (Delegate leaks for naive Cocoa Toolbars (unified toolbar))

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline