Reviewing merge request #2632: Do not rely on _NET_WORKAREA for availableGeometry(screen).

Do not rely on _NET_WORKAREA for availableGeometry(screen).

_NET_WORKAREA is not reliable in a multi-monitor setup as it exposes only one rectangular area spanning all screens.

Task-number: QTBUG-18380

Commits that would be merged:

Version 3
  • Version 1
  • Version 1
  • Version 2
  • Version 3
  • Version 3
  • Version 3
  • 24cd118
  • c60dd2a

    • Do not rely on _NET_WORKAREA for availableGeometry(screen).

Showing 24cd118-c60dd2a

Comments

Pushed new version 1

avatar Olivier Tilloy | 2011-06-15 09:53:13 UTC

hi, looks good.
could you please remove the excess braces around the one-line conditional blocks?

avatar Oswald Buddenhagen | 2011-06-15 14:23:47 UTC

Pushed new version 2

avatar Olivier Tilloy | 2011-06-15 16:28:06 UTC

… and please squash the commits …

avatar Oswald Buddenhagen | 2011-06-23 11:37:46 UTC

Pushed new version 3

avatar Olivier Tilloy | 2011-07-11 10:25:21 UTC

Pushed new version 3

avatar Olivier Tilloy | 2011-07-11 10:25:21 UTC

Pushed new version 3

avatar Olivier Tilloy | 2011-07-11 10:25:21 UTC

Commits squashed. Sorry for the delay.

avatar Olivier Tilloy | 2011-07-11 10:26:09 UTC

we have a review bandwidth problem … :}
so you may want to “trade prisoners” at https://qt.gitorious.org/qt/qt/merge_requests/2623

avatar Oswald Buddenhagen | 2011-08-12 13:10:01 UTC

Hey Oswald,
Thanks for your comments and guidance so far.
I wish I had time to contribute to reviewing other merge requests, but I can’t reasonably commit on this. If I do find time then for sure I’ll see what I can review, but I wouldn’t count on it too much (sorry about that).

avatar Olivier Tilloy | 2011-08-18 08:52:43 UTC

This bug actually prevents right-click popup menus from appearing on my second screen (QT 4.7.4).

Any chance we can get this patch merged?

avatar elegantdice | 2012-01-12 04:05:31 UTC

I have applied this patch to my near-vanilla 4.7.4 code and confirm it works for me.

avatar elegantdice | 2012-01-12 06:27:31 UTC

does it related to https://bugreports.qt.nokia.com/browse/QTBUG-19531 ?

avatar Sergey Belyashov | 2012-01-12 16:47:09 UTC

I'm not sure how this would relate to QTBUG-19531.

The original issue that this patch adresses is QTBUG-18380. Of course I'm not discarding that it fixes this other issue as a side effect (would be nice, but at as first glance I don’t see how they would be related).

Have you actually tested that this patches improves the situation in QTBUG-19531?

avatar Olivier Tilloy | 2012-01-14 12:14:15 UTC

→ State changed from New to Closed

Thank you for your contribution. With Qt 4 having moved [1] under Open
Governance [2] as well, you can now contribute your changes via Gerrit
[3]. At the same time, contributions via Gitorious can no longer be
merged.

We would still like to see your patch on the new platform, and wish
for you to become a member of the Qt Project. Please read [4] and in
particular [5] to familiarize yourself with the new tools. You will
still find a read-only mirror of all Qt repositories on Gitorious.

With a much wider set of possible reviewers, we are also looking
forward to better response times to contributions. Looking forward to
your patch!

Please note that at this point in time Qt 4.8 is a bugfix only branch,
and all fixes should be submitted to Qt 5 first, as far as
applicable. Qt 4 master is closed.

The Nokia Qt team

[1] http://labs.qt.nokia.com/2012/01/10/qt-4-moved-to-open-governance/
[2] http://labs.qt.nokia.com/2011/10/21/the-qt-project-is-live/
[3] http://codereview.qt-project.org
[4] http://www.qt-project.org
[5] http://developer.qt.nokia.com/wiki/Gerrit_Introduction

avatar The Qt Project | 2012-01-17 11:36:50 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository