Reviewing merge request #2470: Export qt_directfb_.* functions in plugin as well

These functions can be a big help in debugging rendering errors in an application and can even be handy to use for real functionality. While it requires the app to explicitly link to the plugin (when compiling with -plugin-gfx-directfb this is still much better than not exporting them). Since this was the only use-case for QT_DIRECTFB_PLUGIN

Requested by: AndersBakken
Status: Merged
Source repository: andersbakkens-qt:dfb-plugin-export-functions
Target repository: qt:4.7
Created at: September 8th, 2010 16:06

Commits that would be merged:

Version 1

Version 1

b3f22c1
f7ca48e

Export qt_directfb_.* functions in plugin as well

Showing

Showing b3f22c1-f7ca48e

Comments
Include comments entered inline

→ State changed from New to Merged

Thanks, this looks clean and sensible and has been submitted to our staging branches for a final scrubbing before landing in the main Qt 4.7 branch, hopefully in the next couple hours.

Donald Carr | 2010-09-17 16:02:41 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/2470

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/qt/qt.git \
  refs/merge-requests/2470

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit 4.7..merge-requests/2470

# To apply the changes to your branch:
git checkout 4.7
git merge merge-requests/2470
git push origin 4.7

Reviewing merge request #2470: Export qt_directfb_.* functions in plugin as well

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline