Reviewing merge request #2464: Correct documentation for QNetworkReply::downloadProgress

The docs for QNetworkReply downloadProgress and uploadProgress state that you can connect them directly to the QProgressBar::setValue slot. The signal has a qint64 parameter, and setValue takes int, so that is not actually possible.

Requested by: John Brooks
Status: Merged
Source repository: special-qt:qnetworkreply-doc
Target repository: qt:4.7
Created at: September 1st, 2010 03:03

Commits that would be merged:

Version 1

Version 1

8829924
4c8ea0c

Correct QNetworkReply::downloadProgress and uploadProgress docs

Showing

Showing 8829924-4c8ea0c

Comments
Include comments entered inline

→ State changed from New to Merged

Thanks for the correction.

dboddie | 2010-09-08 16:30:06 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/2464

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/qt/qt.git \
  refs/merge-requests/2464

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit 4.7..merge-requests/2464

# To apply the changes to your branch:
git checkout 4.7
git merge merge-requests/2464
git push origin 4.7

Reviewing merge request #2464: Correct documentation for QNetworkReply::downloadProgress

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline