Reviewing merge request #2304: UI improvements in the qdbusviewer

Use splitters instead of QLayouts and allow filtering the services list.

Requested by: Stephen Kelly
Status: Merged
Source repository: steveires-clone:qdbusviewer_ui
Target repository: qt:4.6
Created at: February 11th, 2010 15:36

Commits that would be merged:

Version 1

Version 1

c0179a6
f77116b

Ui improvements to QDBusViewer.

Showing

Showing c0179a6-f77116b

Comments
Include comments entered inline

→ State changed from New to Reviewing

Thanks, patch looks good.

Thiago Macieira | 2010-02-19 15:42:24 UTC

→ State changed from Reviewing to Merged

Thanks for the patch. I've also added a placeholder text into the filter line edit to make sure users know why it’s there.

The merge should show up in the 4.7 branch very soon.

Harald Fernengel | 2010-03-11 14:00:49 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/2304

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/qt/qt.git \
  refs/merge-requests/2304

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit 4.6..merge-requests/2304

# To apply the changes to your branch:
git checkout 4.6
git merge merge-requests/2304
git push origin 4.6

Reviewing merge request #2304: UI improvements in the qdbusviewer

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline