Reviewing merge request #2291: Fixed QTBUG-4201- Artifacts being painted in the focus rect when using stylesheet - Mac OS X

Made sure the parent widgets are drawn into the focus rect's area before, so the artifacts are gone.

Test code see QTBUG-4201.

Commits that would be merged:

Version 1
  • Version 1
  • 8ebad80
  • ef97364

    • Make sure the focus frame is visibile correcly w/o funny traces from the

  • 68c5db8

    • Not red, transparent. This will fix QTBUG-4201

Showing 8ebad80-ef97364

Comments

This looks a bit hacky to me.. assembling a widget list and drawing all ancestor and sibling widgets is certainly not what you would expect a call to draw CE_FocusFrame would do.

Are you sure this is a good idea?

avatar msorvig | 2010-01-27 13:09:52 UTC

Yes, you’re right, it’s not exactly a clean solution. Additionally, it has only to be done if QStyleSheets are used (or were used at some point). I've not found a way to figure that out.

Since the guys handling that bug report found it not that important and I guess non-Coca will be discontinued at some point(?) I don’t think it’s that bad.

avatar Christoph Schleifenbaum | 2010-01-27 13:22:43 UTC

→ State changed from New to Rejected

Hum, as it is, this patch is way too hackish for me. And it will be reported as a performance regression if we integrate it.

Also note that the patch does not follow the coding style of Qt. The coding style is documented here: http://qt.gitorious.org/qt/pages/QtCodingStyle

avatar Benjamin Poulain | 2010-01-31 18:27:35 UTC

fixed by MR#660

avatar Konstantin Ritt | 2010-11-29 02:41:41 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository