Reviewing merge request #1881: Fixed qmake to run extra compilers in the build dir

See
* [207079 - Qmake can't find resources when doing out-of-tree builds](http://qt.nokia.com/developer/task-tracker/index_html?method=entry&id=207079)
* [Problem in building outside source directory(loading qrc files fails)](http://www.qtcentre.org/forum/f-installation-and-deployment-5/t-problem-in-building-outside-source-directoryloading-qrc-files-fails-24801.html)

More information:
See first comment for an example directory structure. Building in "BUILD-A" works, but building in "BUILD-B" doesn't. This patch fixes the problem (working directory of extra compilers - such as rcc).

Commits that would be merged:

Version 1
  • Version 1
  • 52aef13
  • 097025f

    • Fixed qmake to run extra compilers in the build dir.

Showing 52aef13-097025f

Comments

Example directory structure:

.
|-- BUILD-A             # parallel to project root    
|   `-- Makefile        # qmake ../project/project.pro    
`-- project    
    |-- BUILD-B         # within project root    
    |   `-- Makefile    # qmake ../project.pro    
    |-- resources    
    |   `-- ...    
    |-- src    
    |   `-- ...    
    |-- project.pro    
    `-- project.qrc

avatar J-P Nurmi | 2009-10-22 11:34:25 UTC

→ State changed from New to Merged

Thanks, merged as 7f1d1d94160e9ef4da85eb2780ab17af1a482848.

This fixes a weird warning I was having while building the webscraps demo.

avatar Thiago Macieira | 2009-12-02 19:57:58 UTC

→ State changed from Merged to Revise and resubmit

I had to revert this commit because it broke shadow builds.

From a clean source tree, run configure && make in a directory that is a sibling of the source tree. Configure completes, but make fails as qmake cannot find it’s project files.

avatar Bradley T. Hughes | 2009-12-03 08:52:29 UTC

→ State changed from Revise and resubmit to Rejected

ok, i’ll just reject it until further notice. i have this master plan to rewrite qmake’s generators, so this patch should become inapplicable at some point anyway.

avatar Oswald Buddenhagen | 2010-04-08 09:33:24 UTC

Hi! Thanks Ossi, good to hear that it will be eventually fixed at some point.

We are struggling with this problem in the UIEMO project (you know the “Hb” stuff). We generate a .qrc file at configure time, and referring to a .qrc (located in a separate build dir) causes problems to qmake/rcc when doing shadow builds. Thus, as a temporary solution we generate the .qrc file in the source tree. :(

avatar J-P Nurmi | 2010-04-15 16:00:45 UTC

fwiw, i pushed b139e7e9 which also causes the dep commands being run in the build dir, only with “slightly” less side effects (i hope …).

avatar Oswald Buddenhagen | 2010-07-07 09:49:54 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository