Reviewing merge request #1664: Fixed QAudioDeviceInfoInternal::deviceList(QAudio::Mode mode) filtering

If an audio device only supported Input or Output, it would not be added
to the list of devices. Only devices that returned IOID == NULL would be
added. Also, _m was not being used, and io was unneccessarily being cast
to a QString.

Requested by: Martin Banky
Status: Merged
Source repository: mbankys-clone:4.6-multimedia-patches
Target repository: qt:4.6
Created at: October 1st, 2009 06:09

Commits that would be merged:

Version 1

Version 1

e8fc662
d971798

Fixed QAudioDeviceInfoInternal::deviceList(QAudio::Mode mode) filtering

Showing

Showing e8fc662-d971798

Comments
Include comments entered inline

→ State changed from New to Reviewing

Kurt Korbatits | 2009-10-05 22:08:45 UTC

→ State changed from Reviewing to Revise and resubmit

Kurt Korbatits | 2009-10-05 22:32:42 UTC

→ State changed from Revise and resubmit to Merged

Kurt Korbatits | 2009-10-06 03:23:27 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/1664

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/qt/qt.git \
  refs/merge-requests/1664

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit 4.6..merge-requests/1664

# To apply the changes to your branch:
git checkout 4.6
git merge merge-requests/1664
git push origin 4.6

Reviewing merge request #1664: Fixed QAudioDeviceInfoInternal::deviceList(QAudio::Mode mode) filtering

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline