Reviewing merge request #1661: Added setFlag(flag,bool) to the convenience view items
A bit more convenience to the convenience views. It's really basics, but evidently many beginners have problems with bitwise operators:
- http://www.qtcentre.org/forum/f-newbie-4/t-qtablewidget-14373.html#9
- http://www.qtcentre.org/forum/f-qt-programming-2/t-qtablewidgetitems-setflags--4086.html
- http://www.qtcentre.org/forum/f-qt-programming-2/t-make-each-row-of-table-widget-not-editable-4049.html
...
- Requested by:
J-P Nurmi - Status: Closed
- Source repository: jpnurmi-qt:setflag
- Target repository: qt:master
- Created at: September 30th, 2009 20:29
Commits that would be merged:
Comments
Code Looks good.
It is missing a test
(I have also seen people having problem with setFlags)
Thank you for your contribution. With Qt 4 having moved [1] under Open
Governance [2] as well, you can now contribute your changes via Gerrit
[3]. At the same time, contributions via Gitorious can no longer be
merged.
We would still like to see your patch on the new platform, and wish
for you to become a member of the Qt Project. Please read [4] and in
particular [5] to familiarize yourself with the new tools. You will
still find a read-only mirror of all Qt repositories on Gitorious.
With a much wider set of possible reviewers, we are also looking
forward to better response times to contributions. Looking forward to
your patch!
Please note that at this point in time Qt 4.8 is a bugfix only branch,
and all fixes should be submitted to Qt 5 first, as far as
applicable. Qt 4 master is closed.
The Nokia Qt team
[1] http://labs.qt.nokia.com/2012/01/10/qt-4-moved-to-open-governance/
[2] http://labs.qt.nokia.com/2011/10/21/the-qt-project-is-live/
[3] http://codereview.qt-project.org
[4] http://www.qt-project.org
[5] http://developer.qt.nokia.com/wiki/Gerrit_Introduction
Add a new comment:
Login or create an account to post a comment