Reviewing merge request #1469: Fix for QTBUG-22735 Stack overwrite in QDBusDemarshaller
See the bug report https://bugreports.qt.nokia.com/browse/QTBUG-22735 and commit messages.
Commits that would be merged:
Comments
Pushed new version 1
Pushed new version 2
Add initialization of returned data in qIterGet according to comments in the original PMO bug.
Pushed new version 3
Looks good to me, although it doesn’t solve non-pointers getting interpreted as pointers (probably best handled separately).
(I am a D-Bus developer but not a Qt developer.)
Please submit this to Gerrit first, so I can approve it there.
Also: this is strictly a work around for a bug in someone else’s code. The test itself is bogus: you should not decode a type by anything different than the type itself.
Please submit this to Gerrit first, so I can approve it there.
This fix is targeting Qt 4.7 and Qt 4 is not yet available on gerrit (checked from #qt-labs).
Pushed new version 4
Pushed new version 4:
Changed incorrect term “stack overflow” to “stack overwrite” in code comment.
the fix has to be ported to qt5 anyway; it is not acceptable not to merge it there. so you can do that now just as well.
Update: I have a Qt 5 patch ready, but I am experiencing some delays getting my contributor agreement approved. Once I get the rights I will push the patch to Qt 5 and publish its link here and in the bug report.
Finally got this pushed to Qt5 gerrit: http://codereview.qt-project.org/#change,9500
Pushed new version 5
Pushed new version 6
Fixed issues found in Qt 5 gerrit review here too.
merged to 4.8
merged to 4.8
This merge request targets Qt 4.7. It seems to be merged to Qt 4.8 causing tst_QDBusMarshall to fail. Merge request https://qt.gitorious.org/qt/qt/merge_requests/1489 will fix the test failure.
This merge request targets Qt 4.7. It seems to be merged to Qt 4.8 causing tst_QDBusMarshall to fail. Merge request https://qt.gitorious.org/qt/qt/merge_requests/1489 will fix the test failure.
Fix to tst_QDBusMarshall::demarshallPrimitives() failure merged to Qt 4.8 as commit b34d903466a34668973030341e2f12d2b481ed58 via gerrit change http://codereview.qt-project.org/#change,13398.


Add a new comment:
Login or create an account to post a comment