Reviewing merge request #1457: Fix memory leaks in XML DOM parsing

Commits that would be merged:

Version 1
  • Version 1
  • 05737f5
  • 728b6b7
  • Fix memory leak in QDomDocument DTD notation declaration handler

  • 29a3ebe
  • Fix memory leak in QDomDocument DTD entity declaration handler

Showing 05737f5-728b6b7

Comments

Pushed new version 1

Pushed the fixes to Qt5 gerrit because this merge request does not
seem to move forward:
http://codereview.qt-project.org/#change,12256
http://codereview.qt-project.org/#change,12257

→ State changed from New to Closed

Thank you for your contribution. With Qt 4 having moved [1] under Open
Governance [2] as well, you can now contribute your changes via Gerrit
[3]. At the same time, contributions via Gitorious can no longer be
merged.

We would still like to see your patch on the new platform, and wish
for you to become a member of the Qt Project. Please read [4] and in
particular [5] to familiarize yourself with the new tools. You will
still find a read-only mirror of all Qt repositories on Gitorious.

With a much wider set of possible reviewers, we are also looking
forward to better response times to contributions. Looking forward to
your patch!

Please note that at this point in time Qt 4.8 is a bugfix only branch,
and all fixes should be submitted to Qt 5 first, as far as
applicable. Qt 4 master is closed.

The Nokia Qt team

[1] http://labs.qt.nokia.com/2012/01/10/qt-4-moved-to-open-governance/
[2] http://labs.qt.nokia.com/2011/10/21/the-qt-project-is-live/
[3] http://codereview.qt-project.org
[4] http://www.qt-project.org
[5] http://developer.qt.nokia.com/wiki/Gerrit_Introduction

→ State changed from New to Closed

Pushed the fixes to Qt4.8 via gerrit:
http://codereview.qt-project.org/13269
http://codereview.qt-project.org/13270

Closing this request as changes have been pushed to gerrit

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository