Commit 3b7164b3188e9382510bef2211e82ef777faa75c

Fixed casual crash in initializeDb (Symbian)

dynamic_cast should be used carefully with rvct before version 4.

We found that out after the a dynamic (down)-cast from CFont* to
CFbsFont* in QtGui suddenly failed.

We test for (TypeUid() == KCFbsFontUid), before doing the
cast. So, a static_cast is safe in this case. Also the other
two dynamic_casts in qfontdatabase_s60.cpp were changed to
static_cast.

http://bugreports.qt.nokia.com/browse/QTBUG-7963

Task-number: QTBUG-7963
Reviewed-by: lars

	modified:   src/gui/text/qfontdatabase_s60.cpp
src/gui/text/qfontdatabase_s60.cpp
(5 / 6)
  
246246 QSymbianFbsHeapLock lock(QSymbianFbsHeapLock::Unlock);
247247
248248 const int numTypeFaces = QS60Data::screenDevice()->NumTypefaces();
249 const QFontDatabaseS60StoreImplementation *store = dynamic_cast<const QFontDatabaseS60StoreImplementation*>(db->s60Store);
250 Q_ASSERT(store);
249 const QFontDatabaseS60StoreImplementation *store =
250 static_cast<const QFontDatabaseS60StoreImplementation*>(db->s60Store);
251251 bool fontAdded = false;
252252 for (int i = 0; i < numTypeFaces; i++) {
253253 TTypefaceSupport typefaceSupport;
……
258258 continue;
259259 if (font->TypeUid() == KCFbsFontUid) {
260260 TOpenFontFaceAttrib faceAttrib;
261 const CFbsFont *cfbsFont = dynamic_cast<const CFbsFont *>(font);
262 Q_ASSERT(cfbsFont);
261 const CFbsFont *cfbsFont = static_cast<const CFbsFont *>(font);
263262 cfbsFont->GetFaceAttrib(faceAttrib);
264263
265264 QtFontStyle::Key styleKey;
……
389389 QFontDef request = req;
390390 request.family = fontFamily;
391391#if defined(QT_NO_FREETYPE)
392 const QFontDatabaseS60StoreImplementation *store = dynamic_cast<const QFontDatabaseS60StoreImplementation*>(db->s60Store);
393 Q_ASSERT(store);
392 const QFontDatabaseS60StoreImplementation *store =
393 static_cast<const QFontDatabaseS60StoreImplementation*>(db->s60Store);
394394 const QFontEngineS60Extensions *extension = store->extension(fontFamily);
395395 fe = new QFontEngineS60(request, extension);
396396#else