Reviewing merge request #104: + OpenEditorsTabBar: represents open editors (open files) in tab bar manner.
The OpenEditorsTabBar is a simple GUI component looking as ordinary tab bar (it is realized through QTabBar). I found a tab bar more useful control for editor switching with mouse than QtCreator's controls: editor drop-down list and left panel navigation widget under "Open Documents" mode. In addition the OpenEditorsTabBar allows tabs free reordering (QtCreator's controls support alphabetical ordering only) and keeps the order between sessions.
- Requested by:
akon - Status: Rejected
- Source repository: akons-qt-creator:master
- Target repository: qt-creator:master
- Created at: January 23rd, 2010 18:31
Commits that would be merged:
Comments
Regardless of how the open editors tab bar works, this merge request is not acceptable due to:
- The
AKON_CONTRIBUTIONdefine
- The
Akonnamespace
- The dual GPL/LGPL licensing (for Nokia to accept this code in Qt Creator, it needs to be possible to also make the commercial release with it).
- Not following the Qt Creator coding style (for example, filenames with upper case and member variables that aren’t prefixed with
m_but instead postfixed with_).
- Including a Doxygen file to document three files.
If you would be willing to fix these problems, just say so, then it would be worth looking into whether the functionality as such is acceptable.
No problems. Thanks for detailed comment.
Hi,
we don’t want to maintain an additional editor tab bar in Qt Creator.
The thing I could vaguely imagine would be the option to allow reordering the items in the Open Documents panel, though it’s not clear to me what advantage this should bring.
Add a new comment:
Login or create an account to post a comment