Reviewing merge request #100: fakevim: small behavioral changes

don't insert any keyboard input into the text while in command mode - also if the pressed keys are not handled by FakeVim
- in vim, this does not happen either

exit shortcut passing mode immediately after one shortcut has been received
- but: if a shortcut if bound to an action which is not active, this shortcut will not leave passing mode
- still this seems more natural to me

Requested by: Martin Aumüller
Status: Merged
Source repository: aumuells-clone:fakevim/changes
Target repository: qt-creator:master
Created at: January 15th, 2010 13:06

Commits that would be merged:

Version 1

Version 1

fb3ae97
cc63288

don't allow keys with empty text to reset the currently selected completion item

4d39ec3

fakevim: leave shortcut-passing mode after one shortcut has been pressed

Showing

Showing fb3ae97-cc63288

Comments
Include comments entered inline

→ State changed from New to Merged

Merged, thanks.

apoenitz | 2010-01-21 17:12:12 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/100

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/qt-creator/qt-creator.git \
  refs/merge-requests/100

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/100

# To apply the changes to your branch:
git checkout master
git merge merge-requests/100
git push origin master

Reviewing merge request #100: fakevim: small behavioral changes

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline