Reviewing merge request #15: Busy indicator

New version based on images and rotation animation.

Commits that would be merged:

Version 4
  • Version 1
  • Version 2
  • Version 3
  • Version 4
Showing 73e65cd-260255c

Comments

Pushed new version 1

avatar Aleksey Sidorov | 2011-12-05 20:42:08 UTC

→ State changed from New to Need Info

Before I can consider this I need to know if you are the original copyright holder of the actual painting code. As far as I can tell this code has been used in several other projects under different copyrights and you have to be the actual copyright holder in order to modify and give me rights to use it.

avatar jbache | 2011-12-09 10:02:03 UTC

Painting code is a completely rewritten code from this example
http://qt-apps.org/content/show.php/QProgressIndicator?content=115762

avatar Aleksey Sidorov | 2011-12-09 16:51:41 UTC

I think this approach limits the appearance and the behavior of the BusyIndicator.
I think it would be better to have a component written in pure QML, using an Image and a rotation animation.

Something like the following:
https://qt.gitorious.org/qt-components/qt-components/blobs/master/src/meego/BusyIndicator.qml

avatar Adriano Tinoco d'Oliveira Rezende | 2011-12-12 14:20:59 UTC

Pushed new version 2

avatar Aleksey Sidorov | 2012-01-13 12:08:35 UTC

Pushed new version 3

avatar Aleksey Sidorov | 2012-01-13 12:09:30 UTC

Pushed new version 4

avatar Aleksey Sidorov | 2012-01-13 12:14:32 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository