Reviewing merge request #10: Add RowLayout and ColumnLayout components

Commits that would be merged:

Version 2
  • Version 1
  • Version 2
  • 0959b13
  • 439fa8a

    • Added LinearLayout component

  • af5726f

    • Added a LinearLayout example

  • 846adac

    • Adjusted LinearLayout to propagate values to upper levels

  • 9398226

    • Split LinearLayout into RowLayout and ColumnLayout to be aligned with QtQuick

  • ddfbfa8

    • Changed Layout API to be compliant with the latest proposal

  • 29f5399

    • Changed layout headers license to BSD

Showing 0959b13-439fa8a

Comments

Pushed new version 1

avatar Adriano Tinoco d'Oliveira Rezende | 2011-10-28 15:31:12 UTC

→ State changed from New to Reviewing

Thanks for applying this. But do you think the non-commercial clause makes sense?
At the moment, the repo code is BSD so people can use it without warranty commercially even if Nokia does not officially support it yet. I discussed this with legal and they were ok with it. I noticed that some of the headers are inconsistent at the moment so we would have to align them but we might as well start with this one.

avatar jbache | 2011-10-29 07:38:28 UTC

No, I would also prefer BSD. I just thought the LGPL headers were the official ones.
I’ll push a new commit with the BSD licenses.

avatar Adriano Tinoco d'Oliveira Rezende | 2011-10-31 13:03:28 UTC

Pushed new version 2

avatar Adriano Tinoco d'Oliveira Rezende | 2011-10-31 13:06:47 UTC

Hey Jens, are these the right headers?

avatar Adriano Tinoco d'Oliveira Rezende | 2011-11-04 15:58:37 UTC

→ State changed from Reviewing to Merged

Sorry for the delay. I have been a bit busy on mobile stuff lately. Almost correct. I noticed they said (part of Q ts examples) But I will anyway have to go through and clean up this at some point so I merged it. Looks good otherwise.

avatar jbache | 2011-11-15 22:21:45 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository