Reviewing merge request #78: Added support for pure virtual methods returning void pointers
The generated code didn't specify any return value for pure virtual methods with return type of void*, thus breaking the generated code. The return value is now set to 0 by default.
- Requested by:
Matti Airas - Status: Merged
- Source repository: mairas-shiboken:purevirtualvoidptr
- Target repository: shiboken:master
- Created at: March 17th, 2010 17:55
Commits that would be merged:
Comments
- struct SecrectClass : public Abstract {
Would be nice to have this typo fix in another separated commit.
Hugo Parente Lima |
2010-03-17 18:17:48 UTC
on tests/libsample/derived.cpp
- s << ' ';
Just cosmetic stuff, but I think that this change will cause the generator to print “return ;” when the function “returns” void, instead of the beautifull “return;” =]
Hugo Parente Lima |
2010-03-17 18:20:57 UTC
on cppgenerator.cpp
+ s << INDENT << "return ";
This also could be in a separated commit, because this fixes a diferent bug.
Hugo Parente Lima |
2010-03-17 18:22:25 UTC
on cppgenerator.cpp
Sure, I’ll redo the request.
OK, reformatted as three separate commits. I also paid special attention to the formatting of the generated code this time. ;–)
Thx, merged. My first merge! And I’ll never grow tired of repeating that!
Add a new comment:
Login or create an account to post a comment