Reviewing merge request #7: Put the launcher button in the middle of the quick launch bar, refresh quick launch bar contents if .desktop file directory contents change
- Requested by:
Vesa Halttunen - Status: Go ahead and merge
- Source repository: vesuris-duihome:master
- Target repository: duihome:master
- Created at: February 24th, 2010 14:33
Commits that would be merged:
- a9945e3
- 0612af7
Changes: Put the launcher button in the middle of the quick launch bar, refresh quick launch bar contents if .desktop file directory contents change
a9945e3-0612af7Comments
+ QList<DuiWidget *> newWidgets;
I don’t think we should hard-code the number 4 in the middle of this function. There’s some chance that the number can change, so at least make it a named constant.
Ville Voutilainen |
2010-02-25 09:01:17 UTC
on home/quicklaunchbar.cpp
+ if (quickLaunchButtonLayout->count() == 2) {
What’s the meaning of number two? :)
Ville Voutilainen |
2010-02-25 09:02:41 UTC
on home/quicklaunchbarview.cpp
+ protected slots:
What’s the purpose of this change?
Ville Voutilainen |
2010-02-25 09:04:14 UTC
on home/quicklaunchbarview.h
Looks reasonable, please use named constants for the numbers (the names explain the purpose) and comment on the private->protected change (here, not in the code;)) and then push it.
Add a new comment:
Login or create an account to post a comment